Closed austindrenski closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
0a7e98d
) 93.50% compared to head (a2d93e9
) 93.50%. Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looking for one more approval so we can merge this and address the code coverage failure @benjiro spotted via #219 🙏
Follows #173 and open-feature/dotnet-sdk-contrib#134 to synchronize
ci.yml
between both repos.Story here is a little convoluted, but basically this repo already had the linux and windows tests in one workflow, so for #173 I was able to just condition the new
packaging
job on bothunit-tests-linux
andunit-tests-windows
completing successfully.However, prior to open-feature/dotnet-sdk-contrib#134, the contrib repo had separate workflow files for its respective linux and windows tests, so as part of open-feature/dotnet-sdk-contrib#134, I merged those separate workflows into one workflow and, at the same time, rewrote them to use a job matrix.
For PR consistency, I almost included the same job matrix update as part of #173, but held off in the spirit of doing one thing at a time. So, with that, this PR now syncs the two
ci.yml
files so both will exactly match after open-feature/dotnet-sdk-contrib#134 is merged (anticipated sometime today).Additionally, this PR also includes the
nuget.config
andCONTRIBUTING.md
updates from open-feature/dotnet-sdk-contrib#134. Arguably, these may not be needed by this repo, but I'm including them here for (1) consistency, (2) to promote visibility, and (3) to help advertise that these are available if required and/or helpful to future contributors/bug reporters.