Review requirement IDs used in tests

open-feature / dotnet-sdk

.NET implementation of the OpenFeature SDK

https://openfeature.dev

Apache License 2.0

63 stars 19 forks source link

Review requirement IDs used in tests #204

Open beeme1mr opened 8 months ago

beeme1mr commented 8 months ago

Requirements

The requirement IDs used in the specification changed when we added support for client-side feature flags. The .NET SDK uses those IDs in some tests. These should be reviewed to make sure they match the spec.

Requirements that are out of date:

dotnet-sdk/test/OpenFeature.Tests/OpenFeatureClientTests.cs
- Spec IDs: 1.4.5-1.4.14
dotnet-sdk/test/OpenFeature.Tests/OpenFeatureHookTests.cs
- Spec IDs: 4.3.3-4.3.8

Here's the diff between spec v0.5.2 and v0.8.0.

roelofb commented 8 months ago

The evaluation context also lacks the required 'targeting key` field

https://github.com/open-feature/dotnet-sdk/blob/2c237df6e0ad278ddd8a51add202b797bf81374e/test/OpenFeature.Tests/OpenFeatureEvaluationContextTests.cs#L46

toddbaert commented 8 months ago

@roelofb excellent catch! I've created a bug for this: https://github.com/open-feature/dotnet-sdk/issues/230

roelofb commented 8 months ago

@toddbaert Added a PR: #231