open-feature / dotnet-sdk

.NET implementation of the OpenFeature SDK
https://openfeature.dev
Apache License 2.0
62 stars 17 forks source link

chore: More sln cleanup #206

Closed austindrenski closed 7 months ago

austindrenski commented 7 months ago

Follow up to #202 because I realized a moment too late that my suggestion inadvertently dropped an xref for the original GUID we we're trying to un-dupe.

While I'm in here, adding some additional sln folders so I don't have to keep flipping back and forth from sln view <-> filesystem view. (Hoping these won't be controversial? But open to pulling back on some of this if it rubs anyone the wrong way.)

See: #202

Screencaps

Rider

image

VS Code

image

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0a7e98d) 93.50% compared to head (a5e7664) 93.50%. Report is 3 commits behind head on main.

:exclamation: Current head a5e7664 differs from pull request most recent head a232fcf. Consider uploading reports for the commit a232fcf to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #206 +/- ## ======================================= Coverage 93.50% 93.50% ======================================= Files 23 23 Lines 954 954 Branches 105 105 ======================================= Hits 892 892 Misses 38 38 Partials 24 24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

toddbaert commented 7 months ago

LGTM but needs a DCO it seems.

austindrenski commented 7 months ago

LGTM but needs a DCO it seems.

ope, whoops, fixed now!