open-feature / dotnet-sdk

.NET implementation of the OpenFeature SDK
https://openfeature.dev
Apache License 2.0
62 stars 17 forks source link

fix: Remove reference to NETFramework.ReferenceAssemblies #219

Closed benjiro closed 7 months ago

benjiro commented 7 months ago

This PR

Since turning on CPM the code coverage build has broken, see here

Believe we don't need to reference this anymore as its being implicitly included

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0a7e98d) 93.50% compared to head (57d60f6) 93.50%. Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #219 +/- ## ======================================= Coverage 93.50% 93.50% ======================================= Files 23 23 Lines 954 954 Branches 105 105 ======================================= Hits 892 892 Misses 38 38 Partials 24 24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

austindrenski commented 7 months ago

@benjiro I'm not sure why dotnet test is reporting an error when including the reference assemblies in that report workflow.

AFAIK those reference assemblies don't come for free with the .NET SDK on Linux, which is why we have to include them manually. I know that was at least true in the past, so I guess it might have changed, but idk...

Any chance it's something about codecover being included?

austindrenski commented 7 months ago

Wait scratch that, looks like this workflow might just have gotten messed up?

It looks like it's referencing a matrix variable without defining the strategy matrix:

Screenshot_20240127-144009.png

austindrenski commented 7 months ago

Going to try addressing this as part of #196 which is already cleaning up some other matrices