Closed austindrenski closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
130654b
) 93.50% compared to head (c2fb940
) 93.50%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@CommCody please pull the latest main
and let us know if you have any further build issues. Thanks again for reporting!
@austindrenski I can confirm that main builds for me now
Very silly, had this right in my internal projects and decided to "simplify" it when I reimplemented here 🤦🤦🤦
tldr; NuGet analyzers run over the
Directory.Packages.props
file without validating whether a givenPackageVersion
is used in a given TFM, so the analyzer pops even though the build is happy. I'm still a little confused as to why I can't repro locally, but probably caching, so "un-simplifying" my earlier oops and all should hopefully work as intended going forward.See: #165, #196, #219, #220
H/T @CommCody