open-feature / dotnet-sdk

.NET implementation of the OpenFeature SDK
https://openfeature.dev
Apache License 2.0
62 stars 17 forks source link

fix: Fix NU1009 reference assembly warning #222

Closed austindrenski closed 7 months ago

austindrenski commented 7 months ago

Very silly, had this right in my internal projects and decided to "simplify" it when I reimplemented here 🤦🤦🤦

tldr; NuGet analyzers run over the Directory.Packages.props file without validating whether a given PackageVersion is used in a given TFM, so the analyzer pops even though the build is happy. I'm still a little confused as to why I can't repro locally, but probably caching, so "un-simplifying" my earlier oops and all should hopefully work as intended going forward.

See: #165, #196, #219, #220

H/T @CommCody

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (130654b) 93.50% compared to head (c2fb940) 93.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #222 +/- ## ======================================= Coverage 93.50% 93.50% ======================================= Files 23 23 Lines 954 954 Branches 105 105 ======================================= Hits 892 892 Misses 38 38 Partials 24 24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

austindrenski commented 7 months ago

@CommCody please pull the latest main and let us know if you have any further build issues. Thanks again for reporting!

CommCody commented 7 months ago

@austindrenski I can confirm that main builds for me now