search

open-feature / dotnet-sdk

.NET implementation of the OpenFeature SDK
https://openfeature.dev
Apache License 2.0
61 stars 17 forks source link

fix: Add targeting key #231

Closed roelofb closed 6 months ago

roelofb commented 6 months ago

Fixes #230

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1082094) 94.16% compared to head (cea58b6) 94.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #231 +/- ## ========================================== + Coverage 94.16% 94.28% +0.11% ========================================== Files 25 25 Lines 1046 1067 +21 Branches 112 115 +3 ========================================== + Hits 985 1006 +21 Misses 37 37 Partials 24 24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

roelofb commented 6 months ago

Not sure how to fix this test failure, the test harness looks incredibly involved TBH

toddbaert commented 6 months ago

Not sure how to fix this test failure, the test harness looks incredibly involved TBH

Ya. We have an issue to fix this. I think this is similar to https://github.com/open-feature/dotnet-sdk/pull/223#issuecomment-1927668079. I will try to fix this today.

toddbaert commented 6 months ago

I'll merge this Monday unless anyone objects!

Thanks a lot @roelofb !