Closed toddbaert closed 6 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
1d523cf
) 93.60% compared to head (70b7240
) 94.16%.
Files | Patch % | Lines |
---|---|---|
src/OpenFeature/Providers/Memory/Flag.cs | 96.96% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@askpt Thanks for the review. Please check again when you have time: I added tests and applied all but one of your suggestions.
@askpt Thanks for the review. Please check again when you have time: I added tests and applied all but one of your suggestions.
@toddbaert LGTM! There are some checks still failing
@askpt Thanks for the review. Please check again when you have time: I added tests and applied all but one of your suggestions.
@toddbaert LGTM! There are some checks still failing
Ya I still have to up the coverage a bit.
Implements in-memory provider as per spec, updates gherkin to use spec version, removes flagd deps.
Thanks to @CommCody
I could have added more unit tests for the in-memory provider, but the e2e suite tests most of it. I'll create a "good first issue" for others to add more unit tests, but I'd like to get this merged sooner than later because I believe it's blocking this and this
Resolves: https://github.com/open-feature/dotnet-sdk/issues/165