search

open-feature / dotnet-sdk

.NET implementation of the OpenFeature SDK
https://openfeature.dev
Apache License 2.0
61 stars 17 forks source link

feat!: Use same type for flag metadata and event metadata #241

Closed benjiro closed 4 months ago

benjiro commented 6 months ago

This PR

BREAKING CHANGE, merge with 2.0

The spec describes two types(flag metadata, and event metadata) that are functionally the same. This PR makes a breaking change to bring both of the types to use a generic ImmutableMetadata type.

Related Issues

Fixes: #234

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.46%. Comparing base (11a0333) to head (ee77da9). Report is 4 commits behind head on main.

:exclamation: Current head ee77da9 differs from pull request most recent head 0845fb6. Consider uploading reports for the commit 0845fb6 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #241 +/- ## ========================================== - Coverage 95.40% 94.46% -0.95% ========================================== Files 27 26 -1 Lines 1111 1102 -9 Branches 120 119 -1 ========================================== - Hits 1060 1041 -19 - Misses 34 37 +3 - Partials 17 24 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

beeme1mr commented 4 months ago

Hey @benjiro, we started prepping for the 2.0 release. When you have a moment, could you please resolve the conflicts? Thanks!

toddbaert commented 4 months ago

I've taken this up where @benjiro left off, fixed some conflicts, etc.