open-feature / dotnet-sdk

.NET implementation of the OpenFeature SDK
https://openfeature.dev
Apache License 2.0
61 stars 17 forks source link

chore!: Enable nullable reference types #253

Closed askpt closed 4 months ago

askpt commented 4 months ago

Enable nullable reference types

Related Issues

Fixes #208

Notes

This PR turns on the nullable checks for the dotnet checks. This gives us a better and safer codebase since it checks for potential null exceptions.

Breaking changes

While this PR won't require changes to the exposed API, it might show some errors to the clients consuming it.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 92.30769% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 95.50%. Comparing base (9b9c3fd) to head (0738213).

Files Patch % Lines
src/OpenFeature/EventExecutor.cs 66.66% 0 Missing and 4 partials :warning:
src/OpenFeature/OpenFeatureClient.cs 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #253 +/- ## ========================================== + Coverage 94.47% 95.50% +1.03% ========================================== Files 27 27 Lines 1104 1113 +9 Branches 119 120 +1 ========================================== + Hits 1043 1063 +20 + Misses 37 33 -4 + Partials 24 17 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.