chore: cleanup code - Githubissues

open-feature / dotnet-sdk

.NET implementation of the OpenFeature SDK

https://openfeature.dev

Apache License 2.0

61 stars 17 forks source link

chore: cleanup code #277

Closed askpt closed 1 month ago

askpt commented 1 month ago

This PR

This PR fixes some of the warnings and typos that I recently found. More interestingly, it addresses these issues:

Missing the .this
Usage of ILogger vs Source generator log
const vs static
Fix nullability for some methods and properties. And a few more changes.

Follow-up Tasks

We need to do more cleanup tasks.

How to test

All of these changes are recommended by the IDE and "tested" by the compiler when it executes.

toddbaert commented 1 month ago

Thanks!