search

open-feature / flagd

A feature flag daemon with a Unix philosophy
https://openfeature.dev
Apache License 2.0
510 stars 61 forks source link

chore: adapt telemetry setup error handling #1315

Closed bacherfl closed 4 months ago

bacherfl commented 4 months ago

Closes #1194

This PR adapts the service setup to not fail when encountering an error in the telemetry setup.

netlify[bot] commented 4 months ago

Deploy Preview for polite-licorice-3db33c ready!

Name Link
Latest commit 155bf59f0cf0ab44f2f5998bc25522e4dbd40f1a
Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/6654b7f37e017b000810d2c7
Deploy Preview https://deploy-preview-1315--polite-licorice-3db33c.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 78.71%. Comparing base (1c530ab) to head (155bf59). Report is 65 commits behind head on main.

Files Patch % Lines
core/pkg/telemetry/metrics.go 87.50% 1 Missing :warning:
...agd/pkg/service/flag-evaluation/connect_service.go 87.50% 1 Missing :warning:
...agd/pkg/service/middleware/metrics/http_metrics.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1315 +/- ## ========================================== + Coverage 73.69% 78.71% +5.02% ========================================== Files 32 36 +4 Lines 3140 2824 -316 ========================================== - Hits 2314 2223 -91 + Misses 717 466 -251 - Partials 109 135 +26 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.