search

open-feature / flagd

A feature flag daemon with a Unix philosophy
https://openfeature.dev
Apache License 2.0
510 stars 61 forks source link

chore: fix unit tests and ensure their execution #1316

Closed bacherfl closed 4 months ago

bacherfl commented 4 months ago

When running the tests locally I noticed that one of them was failing in the flagd submodule of the repo. After looking into this, I noticed that the unit tests are only executed for the core package in the PR checks - this is fixed with this PR

netlify[bot] commented 4 months ago

Deploy Preview for polite-licorice-3db33c canceled.

Name Link
Latest commit 77f56fc11d1c44a8ed20d15d3d289d8d24988568
Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/664fa5472f64720008fd7c7e
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.61%. Comparing base (1c530ab) to head (8bff98a). Report is 63 commits behind head on main.

:exclamation: Current head 8bff98a differs from pull request most recent head 77f56fc

Please upload reports for the commit 77f56fc to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1316 +/- ## ========================================== + Coverage 73.69% 78.61% +4.92% ========================================== Files 32 36 +4 Lines 3140 2806 -334 ========================================== - Hits 2314 2206 -108 + Misses 717 465 -252 - Partials 109 135 +26 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.