search

open-feature / flagd

A feature flag daemon with a Unix philosophy
https://openfeature.dev
Apache License 2.0
564 stars 67 forks source link

feat: added new grpc sync config option to allow setting max receive message size. #1358

Closed pradeepbbl closed 4 months ago

pradeepbbl commented 4 months ago

This PR

Added a new config option maxMsgSize which will allow users to override default message size 4Mb.

Related Issues

Fixes #1357

How to test

To test this feature you need a flag source with large number of flags > 4Mb, e.g. below we are running with max size of 5Mb+

./flagd start --port 8013 --sync-port 8017 --sources='[{"uri": "localhost:8015", "provider": "grpc", "tls": false, "providerID": "flagd-sidecar", "selector": "all-flags", "maxMsgSize": 5728474}]'

         ______   __       ________   _______    ______
        /_____/\ /_/\     /_______/\ /______/\  /_____/\
        \::::_\/_\:\ \    \::: _  \ \\::::__\/__\:::_ \ \
         \:\/___/\\:\ \    \::(_)  \ \\:\ /____/\\:\ \ \ \
          \:::._\/ \:\ \____\:: __  \ \\:\\_  _\/ \:\ \ \ \
           \:\ \    \:\/___/\\:.\ \  \ \\:\_\ \ \  \:\/.:| |
            \_\/     \_____\/ \__\/\__\/ \_____\/   \____/_/

2024-07-11T11:31:57.024+0200    info    cmd/start.go:107    flagd version: dev (da01e08), built at: 2024-07-11T11:14:44Z    {"component": "start"}
2024-07-11T11:31:57.026+0200    info    flag-sync/sync_service.go:54    starting flag sync service on port 8017 {"component": "FlagSyncService"}
2024-07-11T11:31:57.027+0200    info    grpc/grpc_sync.go:70    setting max receive message size 5728474 bytes default 4MB  {"component": "sync", "sync": "grpc"}
netlify[bot] commented 4 months ago

Deploy Preview for polite-licorice-3db33c ready!

Name Link
Latest commit 6dfe9b1394fac14daab0611a96aa13a059245370
Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/669147a8d6112a0008040db7
Deploy Preview https://deploy-preview-1358--polite-licorice-3db33c.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Kavindu-Dodan commented 4 months ago

@pradeepbbl DCO failed. Could you please sign your commits? You can follow simple steps here - https://github.com/open-feature/flagd/pull/1358/checks?check_run_id=27331145892