search

open-feature / flagd

A feature flag daemon with a Unix philosophy
https://openfeature.dev
Apache License 2.0
564 stars 67 forks source link

chore: improve gRPC sync service shutdown behavior #1375

Closed Kavindu-Dodan closed 3 months ago

Kavindu-Dodan commented 3 months ago

This PR

Address the discussion https://github.com/open-feature/flagd/discussions/1373

The root cause is the listener closing (Close()), which is already done through grpc server .Stop()

netlify[bot] commented 3 months ago

Deploy Preview for polite-licorice-3db33c canceled.

Name Link
Latest commit 31521beb6e332fcfa51581d5e56323eb8ddf5913
Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/66b110e8316fd70008b03040