search

open-feature / go-sdk-contrib

Community maintained OpenFeature Providers and Hooks for Go
https://openfeature.dev
Apache License 2.0
42 stars 39 forks source link

[CI] golangci-lint is failling for flagd and flagsmith #287

Closed thomaspoignant closed 1 year ago

thomaspoignant commented 1 year ago

I've noticed while opening a pull request that CI is falling for flagd and flagsmith.

/home/runner/work/open-feature/go-sdk-contrib/bin/golangci-lint run --deadline=3m --timeout=3m ./hooks/open-telemetry/...;  /home/runner/work/open-feature/go-sdk-contrib/bin/golangci-lint run --deadline=3m --timeout=3m ./hooks/validator/...;  /home/runner/work/open-feature/go-sdk-contrib/bin/golangci-lint run --deadline=3m --timeout=3m ./providers/configcat/...;  /home/runner/work/open-feature/go-sdk-contrib/bin/golangci-lint run --deadline=3m --timeout=3m ./providers/flagd/...;  /home/runner/work/open-feature/go-sdk-contrib/bin/golangci-lint run --deadline=3m --timeout=3m ./providers/flagsmith/...;  /home/runner/work/open-feature/go-sdk-contrib/bin/golangci-lint run --deadline=3m --timeout=3m ./providers/from-env/...;  /home/runner/work/open-feature/go-sdk-contrib/bin/golangci-lint run --deadline=3m --timeout=3m ./providers/go-feature-flag/...;  /home/runner/work/open-feature/go-sdk-contrib/bin/golangci-lint run --deadline=3m --timeout=3m ./providers/launchdarkly/...;  /home/runner/work/open-feature/go-sdk-contrib/bin/golangci-lint run --deadline=3m --timeout=3m ./tests/flagd/...;
level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/open-feature/go-sdk/pkg/openfeature\""
level=error msg="Running error: 1 error occurred:\n\t* can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/open-feature/go-sdk/pkg/openfeature\"\n\n"
level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/open-feature/go-sdk/pkg/openfeature\""
level=error msg="Running error: 1 error occurred:\n\t* can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/open-feature/go-sdk/pkg/openfeature\"\n\n"
level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/configcat/go-sdk/v7\""
level=error msg="Running error: 1 error occurred:\n\t* can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/configcat/go-sdk/v7\"\n\n"
Error: providers/flagd/pkg/service/service.go:55:34: undeclared name: `connect` (typecheck)
    resolver func(context.Context, *connect.Request[req]) (*connect.Response[resp], error),
                                    ^
Error: providers/flagd/pkg/service/client.go:67:16: undeclared name: `connect` (typecheck)
    var options []connect.ClientOption
                  ^
Error: providers/flagd/pkg/service/client.go:70:29: undeclared name: `connect` (typecheck)
        options = append(options, connect.WithInterceptors(
                                  ^
Error: providers/flagsmith/pkg/provider_test.go:352:3: undeclared name: `flagsmith` (typecheck)
        flagsmith.WithBaseURL(server.URL+"/api/v1/"))
        ^
Error: providers/flagsmith/pkg/provider_test.go:462:3: undeclared name: `flagsmith` (typecheck)
        flagsmith.WithBaseURL(server.URL+"/api/v1/"))
        ^
Error: providers/flagsmith/pkg/provider_test.go:571:3: undeclared name: `flagsmith` (typecheck)
        flagsmith.WithBaseURL(server.URL+"/api/v1/"))
        ^
level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/open-feature/go-sdk/pkg/openfeature\""
level=error msg="Running error: 1 error occurred:\n\t* can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/open-feature/go-sdk/pkg/openfeature\"\n\n"
level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/open-feature/go-sdk/pkg/openfeature\""
level=error msg="Running error: 1 error occurred:\n\t* can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/open-feature/go-sdk/pkg/openfeature\"\n\n"
level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/launchdarkly/go-sdk-common/v3/ldlog\""
level=error msg="Running error: 1 error occurred:\n\t* can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/launchdarkly/go-sdk-common/v3/ldlog\"\n\n"
level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/cucumber/godog\""
level=error msg="Running error: 1 error occurred:\n\t* can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for \"github.com/cucumber/godog\"\n\n"
make: *** [Makefile:16: lint] Error 3
Error: Process completed with exit code 2.
toddbaert commented 1 year ago

Fixed with https://github.com/open-feature/go-sdk-contrib/pull/292