feat: Default port to 8015 if in-process resolver is used. #523

open-feature / go-sdk-contrib

Community maintained OpenFeature Providers and Hooks for Go

https://openfeature.dev

Apache License 2.0

42 stars 38 forks source link

feat: Default port to 8015 if in-process resolver is used. #523 #524

Closed aepfli closed 2 months ago

aepfli commented 3 months ago

closes: #523

This PR

The flagd provider defaults to RPC mode and the corresponding port (8013) using the evaluation proto. If the in-process resolver is selected, it operates in in-process mode using the sync proto, but still uses port 8013, instead of defaulting to the correct port (8015, for the sync proto).

We improve the configuration by defaulting to port 8015 if the in-process resolver is selected.

Kavindu-Dodan commented 3 months ago

Thank you @aepfli for the contribution. I left two suggestions