search

open-feature / go-sdk-contrib

Community maintained OpenFeature Providers and Hooks for Go
https://openfeature.dev
Apache License 2.0
42 stars 38 forks source link

feat(go-feature-flag): GO Feature Flag in process using GO module #546

Closed thomaspoignant closed 1 month ago

thomaspoignant commented 1 month ago

This PR

In this PR we create a new provider for GO Feature Flag in process.

GO Feature Flag can be run as a go module and it was possible to run it like this in https://github.com/open-feature/go-sdk-contrib/tree/main/providers/go-feature-flag BUT this brings a lot of unused dependencies in the provider that are not used if you are using the relay-proxy.

In another PR we will release a refactor that removes the dependency to GO Feature Flag to minimize the provider's dependencies and keep it lightweight if it uses the relay proxy.

Follow-up Tasks

Another PR will come with the refactor of https://github.com/open-feature/go-sdk-contrib/tree/main/providers/go-feature-flag.

thomaspoignant commented 1 month ago

The test failing is in the open-telemetry hook, and from my early analysis, it may be because of the GO version (1.22.5).

toddbaert commented 1 month ago

I'll take a look at this tomorrow and see what I can do abou t the CI issue.

toddbaert commented 1 month ago

@thomaspoignant I fixed the CI issue with some dep updates (done in another branch and merged to main).

toddbaert commented 1 month ago

Can you also add a license file? These recently started causing issues in our releases: https://github.com/open-feature/go-sdk-contrib/pull/554