open-feature / go-sdk-contrib

Community maintained OpenFeature Providers and Hooks for Go
https://openfeature.dev
Apache License 2.0
46 stars 45 forks source link

go-feature-flag-in-process is not in the package #570

Closed zaitera closed 2 months ago

zaitera commented 2 months ago

updated to the latest 0.2.0 but did not want to change my existing usage of the lib, so I wanted to switch to "in-process" part that uses go feature flag under the hood. I cannot use that provider. image image

thomaspoignant commented 2 months ago

Thanks for raising this issue, let me check and I'll get back to you.

thomaspoignant commented 2 months ago

@zaitera I've reproduced your issue on my computer and I think the issue was because it is a brand new package and my go installation had some caching issue.

What I did do to solve the caching issue?

I have forced the version when doing the 1st go get command.

go get github.com/open-feature/go-sdk-contrib/providers/go-feature-flag-in-process@v0.1.0

This has solved the problem and download the module.

Will it work for others?

To be sure it was a caching issue, I also installed a fresh Ubuntu with a brand new go environment. When doing the go get github.com/open-feature/go-sdk-contrib/providers/go-feature-flag-in-process it has worked without specifying any version.

Can you tell me if it has worked for you too? If so don't hesitate to close the issue.

zaitera commented 2 months ago

@thomaspoignant thanks for the quick response, that worked fine!

thomaspoignant commented 2 months ago

I am glad it worked for you 🎉 Thanks for raising it !

zaitera commented 2 months ago

@thomaspoignant just a quick question, what is the reason behind calling it in process? is it something we need to treat carefully and not take to production? because it seems to me it is just the same code that used to be on normal go-feature-flag before that latest update to 0.2.0

thomaspoignant commented 2 months ago

@zaitera it is called in-process because the evaluation is made directly in the provider and is not doing any remote call to the relay-proxy. It is not a reference to the state of the provider and it is production-ready.

zaitera commented 2 months ago

clear, thanks for the quick responses :)