search

open-feature / go-sdk

Go SDK for OpenFeature
https://openfeature.dev
Apache License 2.0
126 stars 30 forks source link

chore: bump Go to version 1.20 #255

Closed odubajDT closed 5 months ago

odubajDT commented 7 months ago

Fixes https://github.com/open-feature/go-sdk/issues/253

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.42%. Comparing base (b624a43) to head (7e5c426). Report is 2 commits behind head on main.

:exclamation: Current head 7e5c426 differs from pull request most recent head 65db40b. Consider uploading reports for the commit 65db40b to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #255 +/- ## ======================================= Coverage 81.42% 81.42% ======================================= Files 10 10 Lines 1163 1163 ======================================= Hits 947 947 Misses 196 196 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Kavindu-Dodan commented 7 months ago

My concern here is the version jump from 1.19 to 1.21. Given SDK is a central piece of OF, I think we should move step-wise (1.19 -> 1.20 -> 1.21) so that adaptation becomes easier where needed. We have a tracking issue for 1.20 already - https://github.com/open-feature/go-sdk/issues/253

Kavindu-Dodan commented 6 months ago

I have upgraded the PR to bump Go version to 1.20. This allows us to upgrade SDK's go version linearly, avoiding unnecessary impact on downstream users.

toddbaert commented 5 months ago

After our meeting I'm sure I can say the TC will not block dropping Go 1.19, as long as the go-maintainers support that.

Go is a particularly fast-moving runtime.

beeme1mr commented 5 months ago

Can we extend the readme to include a section on our support policy?

Kavindu-Dodan commented 5 months ago

Can we extend the readme to include a section on our support policy?

I tried to add this with this commit - https://github.com/open-feature/go-sdk/pull/255/commits/f854ec49213e6c980c35e0f77eafb31813db9f73