search

open-feature / go-sdk

Go SDK for OpenFeature
https://openfeature.dev
Apache License 2.0
126 stars 30 forks source link

feat: Implement domain scoping #261

Closed gunishmatta closed 3 months ago

gunishmatta commented 5 months ago

This PR

Related Issues

Fixes #257

Notes

Follow-up Tasks

How to test

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.74%. Comparing base (266cfc0) to head (37fa69a).

:exclamation: Current head 37fa69a differs from pull request most recent head 012a941

Please upload reports for the commit 012a941 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #261 +/- ## ========================================== - Coverage 81.91% 81.74% -0.17% ========================================== Files 10 10 Lines 962 964 +2 ========================================== Hits 788 788 - Misses 154 156 +2 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gunishmatta commented 5 months ago

Hi Team @beeme1mr @Kavindu-Dodan Thanks for your valuable feedback, Please give me a couple of days, I am out for a vacation, I will update the PR as soon as I get time.

Kavindu-Dodan commented 4 months ago

@gunishmatta really nice work 🙌 could you please check the minor changes I proposed? They should be easy to complete and once done I think this is ready

gunishmatta commented 4 months ago

Hi @Kavindu-Dodan / @beeme1mr I am done with the changes, please merge if looks good.

toddbaert commented 4 months ago

I'll review this tomorrow. Thanks!