[DOC] "go" vs "golang" - Githubissues

open-feature / go-sdk

Go SDK for OpenFeature

https://openfeature.dev

Apache License 2.0

123 stars 29 forks source link

[DOC] "go" vs "golang" #56

Closed agentgonzo closed 1 year ago

agentgonzo commented 1 year ago

Change in the documentation

Whilst it's common to call the language "golang", the official name of the language is "go" (https://en.wikipedia.org/wiki/Go_(programming_language)

Not that it mases a lot of difference, but should we consider renaming the repo (and associated docs) from golang to go?

beeme1mr commented 1 year ago

I don't feel strongly one way or another. We probably should have used "Go" initially but I'm not sure if it's worth changing at this point.

skyerus commented 1 year ago

TIL...

I agree that go-sdk would be better

skyerus commented 1 year ago

[x] Create PRs to replace github.com/open-feature/golang-sdk with github.com/open-feature/go-sdk in known places (providers/tutorials) https://github.com/open-feature/golang-sdk-contrib/issues/24 https://github.com/open-feature/docs.openfeature.dev/issues/117
[x] Alert private provider implementors that the module name is changing (existing imports of the old module name ought to still work but will stop receiving later releases/updates)
[x] Create PR to rename golang-sdk-contrib to go-sdk-contrib https://github.com/open-feature/golang-sdk-contrib/issues/24
[x] Create PR to rename golang-sdk to go-sdk https://github.com/open-feature/golang-sdk/pull/66
[x] Change golang-sdk and golang-sdk-contrib repository names and coordinate the succession of merging the above PRs after

skyerus commented 1 year ago

@beeme1mr all of the related PRs to make this happen are in place, we now just need to cut out some time to rename the golang-sdk & golang-sdk-contrib repositories themselves. Once this has happened all of the PRs other than https://github.com/open-feature/golang-sdk-contrib/issues/24 will be ok to merge straight away (this one will need to rebuild its go.sum but won't take long). I'll reach out to discuss a good time for us to do this on Tuesday perhaps.

beeme1mr commented 1 year ago

There are a handful to known projects using the SDK. Please either create an issue or open a PR once the name has been changed.

https://github.com/open-feature/golang-sdk/network/dependents?package_id=UGFja2FnZS0zMTE3MDg1NzMy

skyerus commented 1 year ago

Renaming complete