fix: run error hook when provider returns error code

jarebudev commented 1 month ago

This PR

ensures that the error hook is ran when the provider returns an error code

Related Issues

Fixes #928

Notes

saw this bug and seemed like a straightforward fix, wasn't sure if anyone has already picked it up so feel free to reject if it's already been taken on

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.26%. Comparing base (27c9114) to head (380b177).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #951 +/- ## ============================================ + Coverage 94.98% 95.26% +0.28% - Complexity 383 392 +9 ============================================ Files 36 37 +1 Lines 877 887 +10 Branches 53 54 +1 ============================================ + Hits 833 845 +12 + Misses 24 23 -1 + Partials 20 19 -1 ``` | [Flag](https://app.codecov.io/gh/open-feature/java-sdk/pull/951/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-feature/java-sdk/pull/951/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | `95.26% <100.00%> (+0.28%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.