changes the types of the Headers used in the OFREP providers to the native fetch API (which we use anyway); this reduces some boilerplate
adds the ability to send optional custom query params to OFREP (web and server)
minor refactors mostly to reduce small duplication (new feature, less code :sunglasses: )
:warning:
EDIT:
This PR also uses NX settings to automatically make ofrep-core a generated dependency of ofrep-web and ofrep (a normal dependency instead of a manual peer). I don't think we want ofrep-core as a peer here, since no API surface area of ofrep-core is seen by consumers, we can keep our own copy without worry of conflict - it's and implementation detail, I believe.
Thanks @lukas-reining ... please see the edit to my description (the bundling change) I made it after you reviewed, and I want to make sure it makes sense to everyone.
This PR:
Headers
used in the OFREP providers to the native fetch API (which we use anyway); this reduces some boilerplate:warning:
EDIT:
This PR also uses NX settings to automatically make ofrep-core a generated dependency of ofrep-web and ofrep (a normal dependency instead of a manual peer). I don't think we want ofrep-core as a peer here, since no API surface area of ofrep-core is seen by consumers, we can keep our own copy without worry of conflict - it's and implementation detail, I believe.
This is what the generated deps look like: