open-feature / js-sdk-contrib

OpenFeature Providers and Hooks for JavaScript
https://openfeature.dev
Apache License 2.0
33 stars 33 forks source link

feat!: use native headers, optional query params #1003

Closed toddbaert closed 1 month ago

toddbaert commented 1 month ago

This PR:

:warning:

EDIT:

This PR also uses NX settings to automatically make ofrep-core a generated dependency of ofrep-web and ofrep (a normal dependency instead of a manual peer). I don't think we want ofrep-core as a peer here, since no API surface area of ofrep-core is seen by consumers, we can keep our own copy without worry of conflict - it's and implementation detail, I believe.

This is what the generated deps look like:

image

toddbaert commented 1 month ago

Change looks good and makes sense!

Thanks @lukas-reining ... please see the edit to my description (the bundling change) I made it after you reviewed, and I want to make sure it makes sense to everyone.