search

open-feature / js-sdk-contrib

OpenFeature Providers and Hooks for JavaScript
https://openfeature.dev
Apache License 2.0
37 stars 37 forks source link

feat: Default port to 8015 if in-process resolver is used. #936 #937

Closed aepfli closed 4 months ago

aepfli commented 5 months ago

closes: #936

This PR

The flagd provider defaults to RPC mode and the corresponding port (8013) using the evaluation proto. If the in-process resolver is selected, it operates in in-process mode using the sync proto, but still uses port 8013, instead of defaulting to the correct port (8015, for the sync proto).

We improve the configuration by defaulting to port 8015 if the in-process resolver is selected.

Related Issues

Fixes #936

beeme1mr commented 4 months ago

@aepfli could you please update the readme when you get a moment?

aepfli commented 4 months ago

@aepfli could you please update the readme when you get a moment?

i am not happy with my edits to the readme - the information is there, but it might be better to structure this differently, i am not sure about this

toddbaert commented 4 months ago

I think the README is good enough, I will merge and perhaps make some small edits.