search

open-feature / open-feature-operator

A Kubernetes feature flag operator
https://openfeature.dev
Apache License 2.0
164 stars 33 forks source link

fix: flagd mgmt port setting ignored #588

Closed toddbaert closed 6 months ago

toddbaert commented 6 months ago

This wasn't being passed to the flagd startup.

Relates to: https://github.com/open-feature/open-feature-operator/pull/587

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a6fa04f) 87.98% compared to head (87772f3) 88.00%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #588 +/- ## ========================================== + Coverage 87.98% 88.00% +0.02% ========================================== Files 10 10 Lines 932 934 +2 ========================================== + Hits 820 822 +2 Misses 89 89 Partials 23 23 ``` | [Files](https://app.codecov.io/gh/open-feature/open-feature-operator/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | Coverage Δ | | |---|---|---| | [apis/core/v1beta1/featureflagsource\_types.go](https://app.codecov.io/gh/open-feature/open-feature-operator/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature#diff-YXBpcy9jb3JlL3YxYmV0YTEvZmVhdHVyZWZsYWdzb3VyY2VfdHlwZXMuZ28=) | `96.59% <100.00%> (ø)` | | | [common/flagdinjector/flagdinjector.go](https://app.codecov.io/gh/open-feature/open-feature-operator/pull/588?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature#diff-Y29tbW9uL2ZsYWdkaW5qZWN0b3IvZmxhZ2RpbmplY3Rvci5nbw==) | `92.09% <100.00%> (+0.04%)` | :arrow_up: | | [Flag](https://app.codecov.io/gh/open-feature/open-feature-operator/pull/588/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | Coverage Δ | | |---|---|---| | [unit-tests](https://app.codecov.io/gh/open-feature/open-feature-operator/pull/588/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | `88.00% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature#carryforward-flags-in-the-pull-request-comment) to find out more.