open-feature / open-feature-operator

A Kubernetes feature flag operator
https://openfeature.dev
Apache License 2.0
164 stars 33 forks source link

feat: auto-upgrade flagd-proxy with OFO upgrades #596

Closed odubajDT closed 5 months ago

odubajDT commented 5 months ago

Fixes: #583

Changes

codecov[bot] commented 5 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (0affaa5) 88.00% compared to head (60217ef) 88.22%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #596 +/- ## ========================================== + Coverage 88.00% 88.22% +0.22% ========================================== Files 10 10 Lines 934 960 +26 ========================================== + Hits 822 847 +25 + Misses 89 88 -1 - Partials 23 25 +2 ``` | [Files](https://app.codecov.io/gh/open-feature/open-feature-operator/pull/596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | Coverage Δ | | |---|---|---| | [common/flagdproxy/flagdproxy.go](https://app.codecov.io/gh/open-feature/open-feature-operator/pull/596?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature#diff-Y29tbW9uL2ZsYWdkcHJveHkvZmxhZ2Rwcm94eS5nbw==) | `88.37% <81.13%> (+1.38%)` | :arrow_up: | | [Flag](https://app.codecov.io/gh/open-feature/open-feature-operator/pull/596/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | Coverage Δ | | |---|---|---| | [unit-tests](https://app.codecov.io/gh/open-feature/open-feature-operator/pull/596/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | `88.22% <81.13%> (+0.22%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature#carryforward-flags-in-the-pull-request-comment) to find out more.
odubajDT commented 5 months ago

Left minor improvement suggestions, otherwise looks good

Adapted, thank you!