open-feature / open-feature-operator

A Kubernetes feature flag operator
https://openfeature.dev
Apache License 2.0
164 stars 33 forks source link

fix: Add capability to skip crd installation during helm install #625

Closed estenrye closed 2 months ago

estenrye commented 2 months ago

This PR

Related Issues

Fixes #624

Notes

Follow-up Tasks

How to test

make helm-package
helm template ./chart/open-feature-operator -s "templates/crds/*.yaml" | kubectl -f -
helm install open-feature ./chart/open-feature-operator --skip-crds --create-namespace -n open-feature
estenrye commented 2 months ago

@beeme1mr I ran the update script like the helm docs linter told me to. can you approve the workflows again?

estenrye commented 2 months ago

@beeme1mr I merged main into my branch since it was ahead of my branch, can you approve the workflow again?

beeme1mr commented 2 months ago

Hey @estenrye , I'll try and trigger the ci when I notice a change but feel free to ping me too. This is only an issue for first-time collaborators. Your next pr will be easier 🙂

estenrye commented 2 months ago

@beeme1mr can you re-run the workflows? I addressed PR feedback, rebased against main and squashed my commits.