search

open-feature / open-feature-operator

A Kubernetes feature flag operator
https://openfeature.dev
Apache License 2.0
164 stars 33 forks source link

sidecarConfiguration.resources in helm chart is ignored #630

Closed mng1dev closed 1 month ago

mng1dev commented 2 months ago

Hello,

I am trying to use the operator and I am installing it via helm chart.

I am passing the following values.yaml file, but it doesn't seem to affect the default properties of the flagd sidecar.

Am I doing anything wrong?

sidecarConfiguration:
  resources:
    requests:
      cpu: 10m
      memory: 16M
    limits:
      cpu: 50m
      memory: 32M
toddbaert commented 1 month ago 
USER-SUPPLIED VALUES:
sidecarConfiguration:
  port: 8078
  resources:
    limits:
      memory: 72M

COMPUTED VALUES:
controllerManager:
...
  resources:
    limits:
      memory: 72M
...

The helm template seems to be working, but the flagd sidecar doesn't seem to use these resources. The other customizations from the sidecarConfiguration seem to work (port, etc), so I think there's a bug here. I'm still investigating.

toddbaert commented 1 month ago

Thanks again @mng1dev . This is fixed with https://github.com/open-feature/open-feature-operator/pull/639 and will be released soon.