search

open-feature / open-feature-operator

A Kubernetes feature flag operator
https://openfeature.dev
Apache License 2.0
164 stars 33 forks source link

fix!: remove flagdResourceEnabled #652

Closed toddbaert closed 1 month ago

toddbaert commented 1 month ago

For https://github.com/open-feature/open-feature-operator/issues/651, I started down the path of maintaining 2 roles and 2 rolebindings, one that controls the extra stuff we need when managerConfig.flagdResourceEnabled is enabled, but after running through some proposed tutorials and dealing with this additional complexity, I honestly think the entire idea of managerConfig.flagdResourceEnabled is not worth it. My reasoning is that it's easy to restrict the creation of flagd CR instances entirely (or instances with ingresses) through many different tools and policies, since these are not created automatically by annotations like some of our other resources. I just don't think we need to control them at the OFO install level.

Sorry @bacherfl for the wasted time here, since this was initially my idea. 😔

Fixes: https://github.com/open-feature/open-feature-operator/issues/651

I tested this locally and it works as expected with Helm.

Kavindu-Dodan commented 1 month ago

I am fine with removing the flagdResourceEnabled option and getting the helm release to a stable state.