open-feature / openfeature.dev

OpenFeature Website
https://openfeature.dev
Creative Commons Attribution 4.0 International
28 stars 47 forks source link

[Provider]: Firebase Remote Config Provider for Swift (community maintained) #423

Open fumito-ito opened 4 months ago

fumito-ito commented 4 months ago

SDK

Other (Not available in the list)

Vendor/Tool

Firebase Remote Config / Swift

Maintainer

Community

Artifacts

This library only supports Swift Package Manager. There is no artifact to link.

Repository

https://github.com/fumito-ito/FirebaseRemoteConfig-OpenFeature-Provider-Swift

Anything else?

[NOTCE!] This is just community maintaining provider for Firebase Remote Config. This library is not officially supported by the vendor.

toddbaert commented 3 months ago

@nicklasl @fabriziodemaria @vahidlazio @nickybondarenko @alina-v1 any chance you guys could take some time to review the provider implemented at the link above?

If it looks good, myself of somebody else can add this to our ecosystem page.

Thanks @fumito-ito !

nicklasl commented 3 months ago

@nicklasl @fabriziodemaria @vahidlazio @nickybondarenko @alina-v1 any chance you guys could take some time to review the provider implemented at the link above?

If it looks good, myself of somebody else can add this to our ecosystem page.

Thanks @fumito-ito !

Sorry for not being able to take a look at this yet. It's on my todo list!

nickybondarenko commented 3 months ago

👋 Hi there! We took a bit of time to have a look at the provider - great job! 🙌 Especially with handling the difference in events and status of the provider (we know that's not yet clear in current version on the SDK). We don't have any major comments, but we were wondering about dropping evaluation context in the provider ( onContextSet() doesn't handle new context, just emits a new status). Ideally we would probably want to poke at Firebase to refetch values at this point - if that is a thing (we're not very familiar with Firebase unfortunately). 👍