open-feature / python-sdk-contrib

Community contributions for hooks and reference providers in python
https://openfeature.dev
10 stars 11 forks source link

refactor!: update imports to the latest version of the sdk #19

Closed federicobond closed 11 months ago

federicobond commented 11 months ago

This PR

Updates imports to the latest version of the Python SDK. It also places the contrib code under the openfeature.contrib namespace. For this to work, openfeature has to be turned into an implicit namespace package by removing the __init__.py file in the sdk (see https://github.com/open-feature/python-sdk/pull/199).

Notes

This requires https://github.com/open-feature/python-sdk/pull/199 to be merged first for the shared namespace to work.

beeme1mr commented 11 months ago

@federicobond I've merged and released the updated SDK.

codecov[bot] commented 11 months ago

Codecov Report

Merging #19 (5ff868c) into main (aabe533) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   83.00%   83.00%           
=======================================
  Files           7        7           
  Lines         100      100           
=======================================
  Hits           83       83           
  Misses         17       17           
Flag Coverage Δ
unittests 83.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
openfeature/contrib/providers/flagd/__init__.py 100.00% <ø> (ø)
openfeature/contrib/providers/flagd/defaults.py 100.00% <ø> (ø)
...b/providers/flagd/evaluation_context_serializer.py 100.00% <100.00%> (ø)
openfeature/contrib/providers/flagd/flag_type.py 100.00% <ø> (ø)
openfeature/contrib/providers/flagd/provider.py 77.77% <100.00%> (ø)
...ure/contrib/providers/flagd/web_api_url_factory.py 74.07% <ø> (ø)
tests/providers/conftest.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

odubajDT commented 11 months ago

Thank you for contribution! :)

federicobond commented 11 months ago

@beeme1mr awesome! merging now that tests pass.