Closed agardnerIT closed 11 months ago
Hey @agardnerIT, thank you for the contribution! Can you please fix the unit tests?
Hi @agardnerIT, I rebased and slightly edited your PR. Commit is still attributed to you.
Merging #20 (9cecb89) into main (5a6d551) will increase coverage by
5.11%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 83.00% 88.11% +5.11%
==========================================
Files 7 7
Lines 100 101 +1
==========================================
+ Hits 83 89 +6
+ Misses 17 12 -5
Flag | Coverage Δ | |
---|---|---|
unittests | 88.11% <100.00%> (+5.11%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Δ | |
---|---|---|
...ure/contrib/providers/flagd/web_api_url_factory.py | 89.28% <100.00%> (+15.21%) |
:arrow_up: |
... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This PR
get_path_for
so it worksRelated Issues
Fixes #17