chore: simplify build and dependencies configuration

open-feature / python-sdk-contrib

Community contributions for hooks and reference providers in python

https://openfeature.dev

11 stars 11 forks source link

chore: simplify build and dependencies configuration #28

Closed federicobond closed 1 year ago

federicobond commented 1 year ago

This PR

Removes pip-compile in favor of pinned development dependencies from a single requirements.txt file [1]
Fixes Makefile targets to improve first contributor user experience
Implements pre-commit hooks matching open-feature/python-sdk
Adds Python 3.11 to the test matrix

Related Issues

Fixes #25, #26

Notes

[1]: Having a single requirements.txt file without transitive dependencies simplifies the maintainers' job, since renovate will only open pull requests when a direct dependency is updated.

federicobond commented 1 year ago

Full diff is a bit messy due to black now applying to pull requests (which apparently it did not before) but it can be reviewed commit by commit.

codecov[bot] commented 1 year ago

Codecov Report

Merging #28 (21c7dd6) into main (0e912ad) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   87.20%   87.20%           
=======================================
  Files           8        8           
  Lines         125      125           
=======================================
  Hits          109      109           
  Misses         16       16

Flag	Coverage Δ
unittests	`87.20% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
openfeature/contrib/hooks/otel.py	`83.33% <ø> (ø)`
openfeature/contrib/providers/flagd/provider.py	`80.00% <ø> (ø)`
tests/providers/conftest.py	`100.00% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-advanced-security[bot] commented 1 year ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.