open-feature / python-sdk-contrib

Community contributions for hooks and reference providers in python
https://openfeature.dev
10 stars 11 forks source link

chore: replace black, flake8 and isort with ruff and ruff-format #30

Closed gruebel closed 8 months ago

gruebel commented 8 months ago

This PR

same as in open-feature/python-sdk#249

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (684a90a) 63.44% compared to head (fd02ae9) 85.12%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #30 +/- ## =========================================== + Coverage 63.44% 85.12% +21.67% =========================================== Files 8 6 -2 Lines 238 121 -117 =========================================== - Hits 151 103 -48 + Misses 87 18 -69 ``` | [Flag](https://app.codecov.io/gh/open-feature/python-sdk-contrib/pull/30/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-feature/python-sdk-contrib/pull/30/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | `85.12% <ø> (+21.67%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-advanced-security[bot] commented 8 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

beeme1mr commented 8 months ago

Did you intend to remove CodeQL?

gruebel commented 8 months ago

@beeme1mr it is still there, previously named pullrequest.yml, now build.yml file. Just need to expand at the bottom of the file, tries to hide itself 😄

beeme1mr commented 8 months ago

🤦 my bad... the change looks good.

gruebel commented 8 months ago

@beeme1mr do you know what the required build (python:3.8) checks are? I don't see them anywhere defined, so not sure why they are hanging.

beeme1mr commented 8 months ago

@beeme1mr do you know what the required build (python:3.8) checks are? I don't see them anywhere defined, so not sure why they are hanging.

The branch protection rules needed to be updated.