Closed gruebel closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
684a90a
) 63.44% compared to head (fd02ae9
) 85.12%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.
Did you intend to remove CodeQL?
@beeme1mr it is still there, previously named pullrequest.yml
, now build.yml
file. Just need to expand at the bottom of the file, tries to hide itself 😄
🤦 my bad... the change looks good.
@beeme1mr do you know what the required build (python:3.8)
checks are? I don't see them anywhere defined, so not sure why they are hanging.
@beeme1mr do you know what the required
build (python:3.8)
checks are? I don't see them anywhere defined, so not sure why they are hanging.
The branch protection rules needed to be updated.
This PR
same as in open-feature/python-sdk#249
merge.yml
andpullrequest.yml
intobuild.yml
, like in thepython-sdk
project, they were almost identical, just the trigger was differentsetup-python
GHA, same as in thepython-sdk
project