search

open-feature / python-sdk-contrib

Community contributions for hooks and reference providers in python
https://openfeature.dev
10 stars 11 forks source link

fix: remove setup from flagd tests #39

Closed federicobond closed 7 months ago

federicobond commented 7 months ago

This PR

Removes the setup function from Flagd tests which was not testing anything useful and was calling the undocumented get_provider function. get_provider was removed from the SDK API in the latest version.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1cef37c) 90.86% compared to head (39128fe) 90.55%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #39 +/- ## ========================================== - Coverage 90.86% 90.55% -0.31% ========================================== Files 8 8 Lines 186 180 -6 ========================================== - Hits 169 163 -6 Misses 17 17 ``` | [Flag](https://app.codecov.io/gh/open-feature/python-sdk-contrib/pull/39/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-feature/python-sdk-contrib/pull/39/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | `90.55% <ø> (-0.31%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.