search

open-feature / python-sdk-contrib

Community contributions for hooks and reference providers in python
https://openfeature.dev
10 stars 11 forks source link

fix: include proto file in build for openfeature-provider-flagd #45

Closed federicobond closed 6 months ago

federicobond commented 6 months ago

This should fix https://github.com/open-feature/python-sdk-contrib/issues/44. hatch now generates the proto client files during the build stage.

We can probably find a cleaner solution later.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 41.02564% with 69 lines in your changes are missing coverage. Please review.

Project coverage is 71.04%. Comparing base (d8e10c7) to head (8e8ff2e). Report is 7 commits behind head on main.

Files Patch % Lines
...ntrib/provider/flagd/proto/schema/v1/schema_pb2.py 24.00% 38 Missing :warning:
.../provider/flagd/proto/schema/v1/schema_pb2_grpc.py 53.73% 31 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #45 +/- ## =========================================== - Coverage 90.55% 71.04% -19.52% =========================================== Files 8 10 +2 Lines 180 297 +117 =========================================== + Hits 163 211 +48 - Misses 17 86 +69 ``` | [Flag](https://app.codecov.io/gh/open-feature/python-sdk-contrib/pull/45/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-feature/python-sdk-contrib/pull/45/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | `71.04% <41.02%> (-19.52%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

federicobond commented 6 months ago

@toddbaert damn, hatch requires python 3.9+. I have to go now, but feel free to edit this PR

gruebel commented 6 months ago

@toddbaert damn, hatch requires python 3.9+. I have to go now, but feel free to edit this PR

the plugin requires Python 3.9 😢

toddbaert commented 6 months ago

@toddbaert damn, hatch requires python 3.9+. I have to go now, but feel free to edit this PR

No worries!

Bummer about 3.8... Looks like it isn't eol until October... Not sure we should drop early, but that's an option.