open-feature / python-sdk-contrib

Community contributions for hooks and reference providers in python
https://openfeature.dev
11 stars 11 forks source link

fix: include targetingKey in flagd serialized evaluation context #58

Closed federicobond closed 8 months ago

federicobond commented 8 months ago

See https://flagd.dev/reference/specifications/rpc-providers/#serialization-of-the-evaluation-context

No tests were added this time but this functionality should be covered with tests against a real flagd server.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.60%. Comparing base (d8e10c7) to head (af1b3fa). Report is 11 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #58 +/- ## ========================================== + Coverage 90.55% 90.60% +0.05% ========================================== Files 8 8 Lines 180 181 +1 ========================================== + Hits 163 164 +1 Misses 17 17 ``` | [Flag](https://app.codecov.io/gh/open-feature/python-sdk-contrib/pull/58/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-feature/python-sdk-contrib/pull/58/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | `90.60% <100.00%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.