search

open-feature / python-sdk-contrib

Community contributions for hooks and reference providers in python
https://openfeature.dev
9 stars 11 forks source link

fix: return proper metadata object in FlagdProvider #59

Closed federicobond closed 6 months ago

federicobond commented 6 months ago

Also removes the name keyword argument from FlagdProvider constructor.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.93%. Comparing base (d8e10c7) to head (e58f0b7). Report is 12 commits behind head on main.

:exclamation: Current head e58f0b7 differs from pull request most recent head c46fab8. Consider uploading reports for the commit c46fab8 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #59 +/- ## ========================================== + Coverage 90.55% 91.93% +1.37% ========================================== Files 8 8 Lines 180 186 +6 ========================================== + Hits 163 171 +8 + Misses 17 15 -2 ``` | [Flag](https://app.codecov.io/gh/open-feature/python-sdk-contrib/pull/59/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-feature/python-sdk-contrib/pull/59/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | `91.93% <100.00%> (+1.37%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.