open-feature / python-sdk-contrib

Community contributions for hooks and reference providers in python
https://openfeature.dev
9 stars 11 forks source link

feat: replace scheme with tls argument in FlagdProvider constructor #61

Closed federicobond closed 6 months ago

federicobond commented 6 months ago

Replace schema parameter which was a leftover from the previous HTTP-based implementation.

The tls parameter now matches what the rest of the provider implementations are using, and maps better to the standard FLAGD_TLS environment variable (not implemented yet).

Note: this is technically a breaking change, but I'd venture that no users would currently be affected.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.02%. Comparing base (d8e10c7) to head (36ed53e). Report is 14 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #61 +/- ## ========================================== + Coverage 90.55% 92.02% +1.46% ========================================== Files 8 8 Lines 180 188 +8 ========================================== + Hits 163 173 +10 + Misses 17 15 -2 ``` | [Flag](https://app.codecov.io/gh/open-feature/python-sdk-contrib/pull/61/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-feature/python-sdk-contrib/pull/61/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | `92.02% <100.00%> (+1.46%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.