open-feature / python-sdk

Python SDK for OpenFeature
https://openfeature.dev
Apache License 2.0
65 stars 18 forks source link

chore: enable mypy strict mode #257

Closed gruebel closed 10 months ago

gruebel commented 10 months ago

This PR

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (30f4e69) 93.83% compared to head (b833562) 93.84%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #257 +/- ## ========================================== + Coverage 93.83% 93.84% +0.01% ========================================== Files 16 16 Lines 438 439 +1 ========================================== + Hits 411 412 +1 Misses 27 27 ``` | [Flag](https://app.codecov.io/gh/open-feature/python-sdk/pull/257/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-feature/python-sdk/pull/257/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | `93.84% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

federicobond commented 10 months ago

Apparently one of the lint rules for ruff conflicts with the mypy configuration:

openfeature/_backports/strenum.py:5:22: PLC0414 Import alias does not rename original package
gruebel commented 10 months ago

@federicobond strange I thought I ran ruff multiple times 🤔 will ignore the rule in this specific line, because there is no other way I know to make both mypy and ruff happy. I prefer mypy to be happy 😄