search

open-feature / python-sdk

Python SDK for OpenFeature
https://openfeature.dev
Apache License 2.0
65 stars 18 forks source link

feat: improve logging setup #261

Closed federicobond closed 9 months ago

federicobond commented 9 months ago

This PR

Replaces the root logger with a custom logger for all logs emitted by the package.

I believe this should cover the logging requirements for the SDK, since logs can be manipulated later via handlers and formatters using the standard library logging package interface.

Follow-up Tasks

codecov[bot] commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (15ce8f9) 93.84% compared to head (bab6c03) 93.89%.

Files Patch % Lines
openfeature/client.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #261 +/- ## ========================================== + Coverage 93.84% 93.89% +0.04% ========================================== Files 16 16 Lines 439 442 +3 ========================================== + Hits 412 415 +3 Misses 27 27 ``` | [Flag](https://app.codecov.io/gh/open-feature/python-sdk/pull/261/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-feature/python-sdk/pull/261/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | `93.89% <75.00%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.