Closed keelerm84 closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
f1b0839
) 93.89% compared to head (fd30717
) 93.89%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @keelerm84! Thank you for your contribution. Change LGTM, but I am lost on what the test is supposed to assert.
If it's just a type check then it should be already covered by mypy. Would any of the tests break if you reverted the type change?
That's a good point. I've removed the useless test and will rely on mypy as suggested.
This PR
Expands the types allowed for
reason
onFlagEvaluationDetails
andFlagResolutionDetails
to include bothReason
andstr
types.Related Issues
Fixes #262
Notes
Related to spec issue: https://github.com/open-feature/spec/issues/236