open-feature / python-sdk

Python SDK for OpenFeature
https://openfeature.dev
Apache License 2.0
48 stars 16 forks source link

refactor: remove abstractmethod decorator from get_provider_hooks #274

Closed federicobond closed 7 months ago

federicobond commented 7 months ago

Remove @abstractmethod decorator which is causing build failures in https://github.com/open-feature/python-sdk-contrib/pull/37#issuecomment-1936528976

The method already provides a default implementation.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f9833ba) 94.41% compared to head (b413401) 94.40%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #274 +/- ## ========================================== - Coverage 94.41% 94.40% -0.02% ========================================== Files 17 17 Lines 448 447 -1 ========================================== - Hits 423 422 -1 Misses 25 25 ``` | [Flag](https://app.codecov.io/gh/open-feature/python-sdk/pull/274/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-feature/python-sdk/pull/274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | `94.40% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.