Closed federicobond closed 5 months ago
Attention: Patch coverage is 98.16514%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 94.77%. Comparing base (
04b4009
) to head (d4420f3
).
Files | Patch % | Lines |
---|---|---|
openfeature/_event_support.py | 97.50% | 1 Missing :warning: |
openfeature/provider/provider.py | 91.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'll take a close look at this in the next couple days.
@federicobond I've opened https://github.com/open-feature/spec/pull/248
This should be ready to review from a specification perspective, we might want to add some further tests maybe.
From Requirement 5.1.1:
Providers cannot emit PROVIDER_CONTEXT_CHANGED or PROVIDER_RECONCILING event.
Should we add a guard to make sure this cannot happen?
@matthewelwell I refactored the EventSupport implementation so that we are no longer using private module imports. It should be much cleaner now.
Merged! 🎉 Thanks everyone for your helpful comments and suggestions.
Amazing, nice job @federicobond!
This PR
Follow-up Tasks
Fixes: https://github.com/open-feature/python-sdk/pull/278