search

open-feature / python-sdk

Python SDK for OpenFeature
https://openfeature.dev
Apache License 2.0
48 stars 16 forks source link

ci: switch to hatch #297

Closed gruebel closed 5 months ago

gruebel commented 5 months ago

This PR

Fixes #59 Fixes #133

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.10%. Comparing base (47ae16c) to head (318f40e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #297 +/- ## ========================================== + Coverage 94.77% 97.10% +2.33% ========================================== Files 20 27 +7 Lines 651 1176 +525 ========================================== + Hits 617 1142 +525 Misses 34 34 ``` | [Flag](https://app.codecov.io/gh/open-feature/python-sdk/pull/297/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/open-feature/python-sdk/pull/297/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature) | `97.10% <ø> (+2.33%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-feature#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

federicobond commented 5 months ago

Nice work! Let's derisk the current release by waiting to merge until after we release event support 🙏

federicobond commented 5 months ago

Sorry for the delay! Looks good to me. Only wondering if we should pin the test dependencies and let renovate handle updates.

gruebel commented 5 months ago

Sorry for the delay! Looks good to me. Only wondering if we should pin the test dependencies and let renovate handle updates.

I have no problem with pinning them, but I couldn't find any info about renovate supporting hatch envs, therefore I'm hesitant to really pin them.

federicobond commented 5 months ago

Ah makes sense, I only thought about the dependencies being in a pyproject.toml file, but renovate needs to support env dependencies explicitly.