Closed federicobond closed 4 months ago
Should AbstractProvider
be importable from openfeature.provider
so we can phase out openfeature.provider.provider
?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.84%. Comparing base (
faf02a9
) to head (b30a492
). Report is 1 commits behind head on main.:exclamation: Current head b30a492 differs from pull request most recent head 5613668. Consider uploading reports for the commit 5613668 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think exposing AbstractProvider
should be done with your other PR #309 then the circular dependency will be gone.
Something weird with the Codecov uploader, @toddbaert @beeme1mr do you know what might be going on?
I think this happens when Codecovs attempts to call the GitHub APIs and are throttled. I just ran one of the failed tests to see if that fixed it. If that doesn't help, I will investigate tomorrow.
Unfortunately, it looks like a very common issue. https://github.com/codecov/codecov-action/issues/598
We should probably only run Codecov once after the python specific tests finish.
Yeah, there is no need to upload the results for each Python version, just one is enough. We can add an if condition to only upload for Python 3.11 as it is the default version for dinner other jobs in the same workflow.
ok, seems like we are not the only ones with the codecov issue https://github.com/codecov/codecov-action/issues/1359 seems like we need to upgrade to v4 with API token.
ok, seems like we are not the only ones with the codecov issue codecov/codecov-action#1359 seems like we need to upgrade to v4 with API token.
Unfortunately, that has challenges too. Perhaps should should consider replacing CodeCov or skipping the upload step for now.
@beeme1mr an alternative could be https://coveralls.io/ thoughts?
I inclined to not rush with the decision and just ignore upload failures in CI temporarily.
Refs https://github.com/open-feature/python-sdk/issues/214
Note: this is a breaking change. We should do an ecosystem check to make sure most packages are using the correct imports.