search

open-feature / python-sdk

Python SDK for OpenFeature
https://openfeature.dev
Apache License 2.0
49 stars 16 forks source link

Create Provider Specific Evaluation Details Object #33

Closed rgrassian-split closed 1 year ago

rgrassian-split commented 1 year ago

Currently the Provider is expected to return a FlagEvaluationDetails object, the same that the client does. However it would probably be better to return a specific ProviderEvaluationDetails object instead so that the flag name does not need to be added and if one changes the other does not have to as well. We do this for the other sdks as well so this would make this sdk similar to them

tcarrio commented 1 year ago

Hey @rgrassian-split, are you referring to a separation of the Evaluation Details and the Resolution Details? As far as I know that's how it is separated, the Resolution Details being the value returned by the provider, and the Evaluation Details being returned by the OpenFeature client.

toddbaert commented 1 year ago

Right! closed in favor of: https://github.com/open-feature/python-sdk/issues/97