open-feature / ruby-sdk

Ruby implementation of the OpenFeature SDK
https://openfeature.dev
Apache License 2.0
21 stars 7 forks source link

feat!: Add `EvaluationContext` helpers and context merging to flag evaluation #119

Closed maxveldink closed 4 months ago

maxveldink commented 4 months ago

This PR

This is largely a port of this behavior from the Sorbet implementation my company originally started with.

Related Issues

Closes #111

Follow-up Tasks

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.46%. Comparing base (6895a0d) to head (984e60a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #119 +/- ## ========================================== + Coverage 99.42% 99.46% +0.03% ========================================== Files 14 15 +1 Lines 174 187 +13 ========================================== + Hits 173 186 +13 Misses 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

maxveldink commented 4 months ago

@beeme1mr Good callout, added some examples

maxveldink commented 4 months ago

I don't think we're overly concerned with thread safety here. We haven't run into any issues with a similar implementation yet. Happy to take a look at any bugs that pop up around that though!