search

open-feature / ruby-sdk

Ruby implementation of the OpenFeature SDK
https://openfeature.dev
Apache License 2.0
21 stars 7 forks source link

Implement Requirement 1.3.4 (type mismatch check in client) #126

Open maxveldink opened 4 months ago

maxveldink commented 4 months ago

While reviewing #124, I realized that we were doing too much work in our InMemoryProvider implementation for verifying type mismatches. In fact, Requirement 1.3.4 indicates that the client should ultimately be checking this for any provider so we don't need to put this guarantee in the individual provider implementations.

We should ensure this requirement is implemented in the client. Then, we should simplify the InMemoryProvider.

mschoenlaub commented 4 months ago

We should ensure this requirement is implemented in the provider.. @maxveldink Shouldn't this say client?

maxveldink commented 3 months ago

Yes, good catch!