search

open-feature / ruby-sdk

Ruby implementation of the OpenFeature SDK
https://openfeature.dev
Apache License 2.0
23 stars 8 forks source link

Increase test coverage #54

Closed mschoenlaub closed 1 year ago

mschoenlaub commented 1 year ago

Not sure where we are at, so we need to measure it. But I don't think we are anywhere near an acceptable threshold, less so for the current version of the spec.

technicalpickles commented 1 year ago

https://github.com/open-feature/ruby-sdk/pull/59 landed, so we are collecting data now. Here's the first report with it enabled: https://github.com/open-feature/ruby-sdk/pull/60#issuecomment-1716282259

CleanShot 2023-09-12 at 16 34 49

link

At 98%, I think we are pretty good. I'm more inclined to worry about the level of coverage when more of the spec is implemented rather worry too much right now.